Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded directory #80361

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@wojtek-t
Copy link
Member

commented Jul 19, 2019

Exactly the same function are living under: staging/src/k8s.io/client-go/tools/ref

Remove GetReference() and GetPartialReference() function from pkg/api/ref, as the same function exists also in staging/src/k8s.io/client-go/tools/ref
@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

/assign @roycaihw

@roycaihw

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Could you add a release note and point to the same function in client-go in the message?

Do we know if anyone can accidentally depend on this package? Should we have a deprecation period, or do we think this is low risk?

@wojtek-t

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Could you add a release note and point to the same function in client-go in the message?

Done

Do we know if anyone can accidentally depend on this package? Should we have a deprecation period, or do we think this is low risk?

I don't think it's needed - if someone depends on the code they need to update their dependency anyway, so at that point they can also switch to call a different one. It's not an API of k8s cluster.

@roycaihw

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

@wojtek-t Sounds good

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 23, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 69a34f6 into kubernetes:master Jul 25, 2019

23 checks passed

cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.