Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Propagate errors from DSW to pod events #80369
What this PR does / why we need it:
The first two bullets are checked also by scheduler, but kubelet should report errors here too, in case a pod runs with a different scheduler or was scheduled manually.
I added list of errors for each pod to DesiredStateOfWorld (DSW), where DSW populator (DSWP) stores them and kubelet picks them up via
I did not want to add errors to
I hope I got the cleaning right - DSWP periodically checks all stored errors and removes those for deleted pods.
I cleaned some error messages on the way, so the events are nice and tidy (well, at least they're better than before, see below).
Natural extension would be to report also mount / set up errors from reconciler ((not part of this PR). By placing the list of errors to DSW, there is no way to pass errors from unmount / teardown (there is no entry in DSW for pods that are being torn down).
Examples (simulating narrow terminal window):
I might send every error as a separate event. Would it be too many events? Does
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
2 times, most recently
Jul 22, 2019
just one thing since the error might be transient, for example, PVC is not created when pod is created. But then PVC is added to desired state, but fail to attach/mount for other reason. When user see the events, will it cause some confusion on what is the reason that pod fails to start?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing