Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NormalizeScore extension point for scheduler framework. #80383

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@liu-cong
Copy link
Contributor

commented Jul 20, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Implement normalize plugin extension point so that normalize plugin can be used.

Which issue(s) this PR fixes:

Fixes #79901
Also helps with #80272

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Implement normalize plugin extension point for the scheduler framework.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Scheduler Framework

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

Welcome @congliu01!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

Hi @congliu01. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness
Copy link
Member

left a comment

/ok-to-test
/priority important-soon

@liu-cong liu-cong force-pushed the liu-cong:normalizescore branch from 8f466b3 to f9f3db0 Jul 21, 2019

@liu-cong liu-cong marked this pull request as ready for review Jul 21, 2019

@draveness
Copy link
Member

left a comment

Looks good, but I think partially fixes would close that issue after this gets merged.

Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/framework_test.go Outdated
@ahg-g

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

/assign

@bsalamat
Copy link
Member

left a comment

A few early comments.

@k8s-ci-robot k8s-ci-robot removed the size/L label Jul 23, 2019

@liu-cong liu-cong force-pushed the liu-cong:normalizescore branch from 9e94fe4 to 6c53a18 Jul 29, 2019

@ahg-g

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

/lgtm

Thanks Cong!

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 29, 2019

@bsalamat
Copy link
Member

left a comment

Thanks, @liu-cong!

Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/framework.go Outdated
Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/framework.go Outdated
Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/framework.go Outdated
Show resolved Hide resolved pkg/scheduler/framework/v1alpha1/interface.go Outdated
Show resolved Hide resolved test/integration/scheduler/framework_test.go

@liu-cong liu-cong force-pushed the liu-cong:normalizescore branch from 6c53a18 to 94f7e1a Jul 30, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 30, 2019

@liu-cong liu-cong force-pushed the liu-cong:normalizescore branch from 94f7e1a to 16d938b Jul 30, 2019

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

/test pull-kubernetes-integration

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

/test pull-kubernetes-e2e-gce-100-performance

2 similar comments
@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

/test pull-kubernetes-e2e-gce-100-performance

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

/test pull-kubernetes-e2e-gce-100-performance

@bsalamat
Copy link
Member

left a comment

Thanks, @liu-cong! Looks good. Just a minor comment.

Show resolved Hide resolved test/integration/scheduler/framework_test.go
Show resolved Hide resolved test/integration/scheduler/framework_test.go Outdated

@liu-cong liu-cong force-pushed the liu-cong:normalizescore branch from 16d938b to 3437366 Jul 31, 2019

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

/test pull-kubernetes-integration

1 similar comment
@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

/test pull-kubernetes-integration

@ahg-g

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 31, 2019

@bsalamat
Copy link
Member

left a comment

/lgtm
/approve

Thanks, @liu-cong!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@liu-cong: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 151c2ee link /test pull-kubernetes-cross
pull-kubernetes-e2e-gce-storage-slow 151c2ee link /test pull-kubernetes-e2e-gce-storage-slow
pull-publishing-bot-validate 151c2ee link /test pull-publishing-bot-validate
pull-kubernetes-conformance-image-test 151c2ee link /test pull-kubernetes-conformance-image-test
pull-kubernetes-e2e-gce-csi-serial 151c2ee link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@draveness
Copy link
Member

left a comment

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit fb46ec8 into kubernetes:master Aug 1, 2019

22 of 23 checks passed

pull-kubernetes-integration Job triggered.
Details
cla/linuxfoundation liu-cong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.