Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix es initial cluster formation & update es to 7.2.0 #80421

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@lostick
Copy link
Contributor

commented Jul 22, 2019

What type of PR is this?
/kind bug
/kind feature

What this PR does / why we need it:
• Fix elasticseatch broken service discovery 7.1.1 upgrade
• Bump elasticsearch / kibana to latest stable (7.2.0)
• Fix makefile indentation

Which issue(s) this PR fixes:
Fixes #80282

Special notes for your reviewer:
• Changes to be pushed onquay.io/fluentd_elasticsearch/elasticsearch before merging.
• Both 7.1.1 and 7.2.0 were built and tested with lostick/fluentd-elasticsearch image.

# elasticsearch health endpoint
$ curl -s  http://elasticsearch-logging:9200/_cluster/health | jq .
{
  "cluster_name": "kubernetes-logging",
  "status": "green",
  "timed_out": false,
  "number_of_nodes": 2,
  "number_of_data_nodes": 2,
  "active_primary_shards": 4,
  "active_shards": 8,
  "relocating_shards": 0,
  "initializing_shards": 0,
  "unassigned_shards": 0,
  "delayed_unassigned_shards": 0,
  "number_of_pending_tasks": 0,
  "number_of_in_flight_fetch": 0,
  "task_max_waiting_in_queue_millis": 0,
  "active_shards_percent_as_number": 100
}

# kibana health endpoint
$ curl -s http://kibana-logging:5601/api/status | jq .status.overall
{
  "state": "green",
  "title": "Green",
  "nickname": "Looking good",
  "icon": "success",
  "uiColor": "secondary",
  "since": "2019-07-22T09:25:01.239Z"
}

Does this PR introduce a user-facing change?:

Kibana has been slightly revamped/improved in the latest version

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

Hi @lostick. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lostick

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

/hold
/assign monotek

@monotek , could you push the changes on quay.io ? thanks.

@lostick

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

/assign @monotek

@monotek

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

/ok-to-test

@monotek

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

/assign @coffeepac

I've already pushed the 7.2.0 image to the docker registry.

@lostick

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

@monotek did you push a 7.2.0 tag with the fixes in https://quay.io/repository/fluentd_elasticsearch/elasticsearch?


build:
docker build --tag ${PREFIX}/${IMAGE}:${TAG} .
docker build --tag ${PREFIX}/${IMAGE}:${TAG} .

This comment has been minimized.

Copy link
@monotek

monotek Jul 24, 2019

Member

please add:

docker build --tag ${PREFIX}/${IMAGE}:latest .

@monotek

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

@monotek did you push a 7.2.0 tag with the fixes in https://quay.io/repository/fluentd_elasticsearch/elasticsearch?

latest tag was missing... therefore push failed...
added latest tag and repushed it...

@lostick lostick force-pushed the lostick:fix-es-master-discovery branch from 16858b1 to 19c0aa9 Jul 24, 2019

@lostick

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

@monotek did you push a 7.2.0 tag with the fixes in https://quay.io/repository/fluentd_elasticsearch/elasticsearch?

latest tag was missing... therefore push failed...
added latest tag and repushed it...

Thanks heaps!

/hold cancel

@monotek
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 24, 2019

@monotek

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lostick, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 10005d2 into kubernetes:master Jul 25, 2019

23 checks passed

cla/linuxfoundation lostick authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.