Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors to kubectl CP command #80436

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@M00nF1sh
Copy link
Contributor

commented Jul 22, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
clean up unused code and refactors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix CVE-2019-11249: Incomplete fixes for CVE-2019-1002101 and CVE-2019-11246, kubectl cp potential directory traversal

@M00nF1sh M00nF1sh changed the title Refactors to kubelet CP command Refactors to kubectl CP command Jul 22, 2019

@k8s-ci-robot k8s-ci-robot requested review from derekwaynecarr and seans3 Jul 22, 2019

@M00nF1sh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

/assign @tallclair

@tallclair

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

/kind bug
/priority important-soon

@M00nF1sh M00nF1sh force-pushed the M00nF1sh:master branch from 3270505 to 9ba6fe8 Jul 22, 2019

@M00nF1sh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@seans3

seans3 approved these changes Jul 22, 2019

Copy link
Contributor

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 22, 2019

@seans3

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08f9f2b into kubernetes:master Jul 22, 2019

23 checks passed

cla/linuxfoundation tallclair authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

M00nF1sh added a commit to M00nF1sh/kubernetes that referenced this pull request Jul 30, 2019

k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019

Merge pull request #80869 from tallclair/automated-cherry-pick-of-#80…
…436-upstream-release-1.15

Automated cherry pick of #80436: refactors to kubernetes CP command

k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019

Merge pull request #80871 from tallclair/automated-cherry-pick-of-#80…
…436-upstream-release-1.13

Automated cherry pick of #80436: refactors to kubernetes CP command

k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019

Merge pull request #80870 from tallclair/automated-cherry-pick-of-#80…
…436-upstream-release-1.14

Automated cherry pick of #80436: refactors to kubernetes CP command
@joelsmith

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

We need to add the following release note:

Fix CVE-2019-11249: Incomplete fixes for CVE-2019-1002101 and CVE-2019-11246, kubectl cp potential directory traversal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.