Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration shim for verifyvolumeattachment and bulk verify #80443

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@davidz627
Copy link
Contributor

commented Jul 22, 2019

VerifyVolumesAreAttached and BulkVolumeVerify were not shimmed to CSI when migration was enabled for the verification plugin. This implements the shim layer for those functions.

However, VerifyVolumesAreAttached for CSI is broken since it checks the VolumeAttachment object which is not currently necessarily representative of what's attached in the backend (if something was detached out of band VolumeAttachment wont see that). and BulkVolumeVerify is not implemented for CSI.

Those are separate issues that can be worked on after this PR.

/kind feature
/sig storage
/assign @msau42 @ddebroy @leakingtapan @saad-ali
/cc @gnufied @jsafrane @andrewsykim @adisky @andyzhangx

Add CSI Migration Shim for VerifyVolumesAreAttached and BulkVolumeVerify
@davidz627

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidz627

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

/assign @jsafrane

@davidz627

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

/retest

@jsafrane
Copy link
Member

left a comment

lgtm, only the logging looks too verbose.

@davidz627 davidz627 force-pushed the davidz627:fix/verifyMigration branch from d0aaaf6 to 8eb2147 Jul 23, 2019

@davidz627 davidz627 force-pushed the davidz627:fix/verifyMigration branch from 8eb2147 to aa91547 Jul 23, 2019

@davidz627 davidz627 force-pushed the davidz627:fix/verifyMigration branch from aa91547 to 290a7f1 Jul 23, 2019

@davidz627

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

/retest

1 similar comment
@davidz627

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

/retest

@davidz627

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

@jsafrane @msau42 comments addressed :)

@jsafrane

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

/lgtm
I think V(4) is OK.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 24, 2019

@k8s-ci-robot k8s-ci-robot merged commit 030274e into kubernetes:master Jul 24, 2019

23 checks passed

cla/linuxfoundation davidz627 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@davidz627 davidz627 deleted the davidz627:fix/verifyMigration branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.