Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'apiserver_watch_events_sizes' #80477

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@mborsz
Copy link
Member

commented Jul 23, 2019

That metric can be used to estimate the size of watch events sent out to the clients.

The size of watch events can be used as an estimate of work done by apiserver.

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added a metric 'apiserver_watch_events_sizes' that can be used to estimate sizes of watch events in the system.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/assign @wojtek-t

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

/assign @roycaihw @jpbetz

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@k8s-ci-robot k8s-ci-robot requested a review from logicalhan Jul 23, 2019

@roycaihw

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

This requires a release note

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

This requires a release note

Why?

Add 'apiserver_watch_events_sizes'.
That metric can be used to estimate the size of watch events sent out to
the clients.

@mborsz mborsz force-pushed the mborsz:eventssize branch from e3bea22 to 4af189a Jul 24, 2019

@roycaihw

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

@wojtek-t The metrics endpoint is user-facing. Something similar to the notes in #78732 should work.

@mborsz

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

I think release notes are a good idea in this case. I added some text. PTAL

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 21, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit ff1e112 into kubernetes:master Aug 22, 2019

23 checks passed

cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.