Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/volume/portworx: Update vendor for libopenstorage/openstorage to v1.0.0 #80495

Merged

Conversation

@adityadani
Copy link
Contributor

commented Jul 23, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
vendor: update for libopenstorage/openstorage to v1.0.0

  • Portworx storage plugin under pkg/volume/portworx uses the libopenstorage/openstorage dependency.
  • This change does not update any of the go files vendor'ed from libopenstorage/openstorage but simply updates the go modules vendor from a SHA to the v1.0.0 tag.

This PR addresses action item 2 and 3, and partially address action item 1 from this comment:
#80281 (comment)

Which issue(s) this PR fixes:
Fixes #80029

Special notes for your reviewer:
The changes are divided into two commits:

  1. Updates the dependencies to use tag v1.0.0 instead of a sha to libopenstorage/openstorage
  2. Update the OWNERS for pkg/volume/portworx

Does this PR introduce a user-facing change?:

Update portworx plugin dependency on libopenstorage/openstorage to v1.0.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig storage
/area code-organization

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

Hi @adityadani. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from rootfs, smarterclayton and kubernetes/dep-approvers Jul 23, 2019

@adityadani

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

/assign @dims

@adityadani

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

@adityadani adityadani force-pushed the adityadani:update_openstorage_to_v1.0.0 branch from d8d769f to 9942eb9 Jul 23, 2019

@saad-ali

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

/assign

Discussion k8s membership offline with @adityadani and @lpabon

@adityadani adityadani force-pushed the adityadani:update_openstorage_to_v1.0.0 branch from 9942eb9 to 9dae95d Jul 24, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

/assign
/ok-to-test

@dims

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

/priority important-soon

@lpabon

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

/retest

1 similar comment
@lpabon

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

/retest

@dims

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/approve
/lgtm

@adityadani once @lpabon accepts the org membership, please rebase this to get rid of do-not-merge/invalid-owners-file

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 25, 2019

@lpabon

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

/approve

@lpabon

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

/assign @thockin

adityadani added some commits Jul 23, 2019

vendor: update for libopenstorage/openstorage to v1.0.0
- Portworx storage plugin under pkg/volume/portworx uses the libopenstorage/openstorage dependency.
- This change does not update any of the go files vendor'ed from libopenstorage/openstorage but simply
  updates the go modules vendor from a SHA to the v1.0.0 tag.

@adityadani adityadani force-pushed the adityadani:update_openstorage_to_v1.0.0 branch from 9dae95d to ab72c09 Jul 25, 2019

@saad-ali

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 25, 2019

@lpabon

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

/approve

@dims

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/assign @thockin @liggitt
/approve
/lgtm

Tim, Jordan, easy one, no change in code, the random SHA was tagged as 1.0.0, needs root OWNERS approval

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adityadani, dims, liggitt, lpabon, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 26, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented Jul 26, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dims

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit de73f62 into kubernetes:master Jul 26, 2019

20 of 23 checks passed

pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
tide Not mergeable. Job pull-kubernetes-integration has not succeeded.
Details
cla/linuxfoundation adityadani authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.