Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detachment of deleted volumes #80518

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@jsafrane
Copy link
Member

commented Jul 24, 2019

/kind bug
/sig storage
/sig openstack

What this PR does / why we need it:
Volumes that were attached to nodes and were forcefully deleted by admin should be considered as detached.

Before this PR, error was returned from Detach() and A/D controller would retry detaching the volume indefinitely.

Does this PR introduce a user-facing change?:

Fixed detachment of deleted volumes on OpenStack / Cinder.

cc: @gnufied @kubernetes/sig-openstack-pr-reviews

Fix detachment of deleted volumes
Volumes that were attached to nodes and were forcefuly deleted by admin
should be considered as detached.
@jsafrane

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

/retest

@gnufied

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/lgtm

@gnufied

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/priority important-soon

@dims

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1a95199 into kubernetes:master Jul 26, 2019

23 checks passed

cla/linuxfoundation jsafrane authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.