Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: handle ResetClusterStatusForNode errors #80573

Conversation

@bart0sh
Copy link
Contributor

commented Jul 25, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Handled errors returned by ResetClusterStatusForNode function when
resetting cluster status for a control-plane node.

Does this PR introduce a user-facing change?:

kubeadm: produce errors if they occur when resetting cluster status for a control-plane node
@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

/test pull-kubernetes-integration

Copy link
Member

left a comment

thanks @bart0sh

Handled errors returned by ResetClusterStatusForNode function when
resetting cluster status for a control-plane node.
@bart0sh bart0sh force-pushed the bart0sh:PR0075-kubeadm-handle-ResetClusterStatusForNode-errors branch from dee3f7f to 5dd9d6a Jul 25, 2019
@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/approve
/priority backlog

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rosti
rosti approved these changes Jul 26, 2019
Copy link
Member

left a comment

Thanks @bart0sh !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8f1eeac into kubernetes:master Jul 26, 2019
23 checks passed
23 checks passed
cla/linuxfoundation bart0sh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.