Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix kubeadm file discovery #80675
What type of PR is this?
What this PR does / why we need it:
This PR fixes this problem and makes possible to do
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: hickeng.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Jul 27, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
hickeng left a comment
I've read through the code change and did not spot any issues - I'm not sufficiently familiar with kubeadm code for that to mean much beyond a cursory check.
I think this API doc needs updating as it's explicitly incorrect once this is merged.
the API comment still seems valid to me. see:
This is currently phrased as an imperative precaution - you must set the bootstrap token just in case the file doesn't contain other authentication information. However with this change, setting the bootstrap token will explicitly prevent the use of other authentication information if present.
This could be rephrased as follows (
I'd suggest a more overt note that token is the primary auth mechanism and will be used in preference of client cert if present.
5 similar comments
@olivierlemasle there is an actual problem with this test job related to the build system.
we should retest once that is fixed.