Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: delete bootstrap-kubelet.conf after TLS bootstrap #80676
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
neolit123 left a comment
i think this is mostly OK, but i recommend adding a
if we really want to be on the safe side there should be a grace period of say 1 release while
EDIT and of course another option is not add this change and leave it to user infrastructure to call
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
i'm -1 given the workaround is very simple:
i worry about somebody is copying or doing something with the bootstrap credentials.
1 similar comment
the delete should be moved to defer here:
otherwise it's possible for the token to be left behind when the function errors