Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public IP not found issues for VMSS nodes #80703

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@feiskyer
Copy link
Member

commented Jul 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug
/sig azure
/priority important-soon

What this PR does / why we need it:

Fix public IP not found issues for VMSS nodes. Without this, controller manager would report the following error when getting the VMSS node's public IP:

Public IP "pub1" not found with message: "network.PublicIPAddressesClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="ResourceNotFound" Message="The Resource 'Microsoft.Network/publicIPAddresses/pub1' under resource group 't-qini-ca-test1' was not found.""

Which issue(s) this PR fixes:

Fixes #80014

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix public IP not found issues for VMSS nodes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 29, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

@k8s-ci-robot k8s-ci-robot requested a review from justaugustus Jul 31, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5413252 into kubernetes:master Jul 31, 2019

23 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG Azure automation moved this from In progress to Done Jul 31, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

@justaugustus thanks

@feiskyer feiskyer deleted the feiskyer:vmss-pip branch Jul 31, 2019

k8s-ci-robot added a commit that referenced this pull request Aug 8, 2019

Merge pull request #81065 from feiskyer/automated-cherry-pick-of-#807…
…03-upstream-release-1.13

Automated cherry pick of #80703: Fix the public IP getting issues for VMSS nodes

k8s-ci-robot added a commit that referenced this pull request Aug 8, 2019

Merge pull request #81064 from feiskyer/automated-cherry-pick-of-#807…
…03-upstream-release-1.14

Automated cherry pick of #80703: Fix the public IP getting issues for VMSS nodes

k8s-ci-robot added a commit that referenced this pull request Aug 8, 2019

Merge pull request #81063 from feiskyer/automated-cherry-pick-of-#807…
…03-upstream-release-1.15

Automated cherry pick of #80703: Fix the public IP getting issues for VMSS nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.