Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NPD version to v0.7.1 for GCI #80726

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@wangzhen127
Copy link
Member

commented Jul 29, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR uses most recent NPD release (v0.7.1) for GCI.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Node-Problem-Detector v0.7.1 is used on GCI.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

/sig node
/priority important-soon
/assign @Random-Liu
/assign @yguo0905
/cc @xueweiz

/hold
We should probably make a new NPD release v0.7.1 to include metrics support for custom plugins. Current v0.7.0 does not include that PR.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@wangzhen127: GitHub didn't allow me to request PR reviews from the following users: xueweiz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/sig node
/priority important-soon
/assign @Random-Liu
/assign @yguo0905
/cc @xueweiz

/hold
We should probably make a new NPD release v0.7.1 to include metrics support for custom plugins. Current v0.7.0 does not include that PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueweiz

This comment has been minimized.

Copy link

commented Jul 29, 2019

By "to include metrics support for custom plugins", you meant #315 right?
I though it's already in 0.7.0?

@xueweiz

This comment has been minimized.

Copy link

commented Jul 29, 2019

(sorry, just realized we are in different repo.
By "315", I meant this:
kubernetes/node-problem-detector#315

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

Ah, my bad, that is included already. I think we can just use v0.7.0 in k8S 1.16.
/hold cancel

@wangzhen127 wangzhen127 changed the title Bump NPD version to v0.7 for GCI Bump NPD version to v0.7.0 for GCI Jul 29, 2019
@wangzhen127 wangzhen127 force-pushed the wangzhen127:npd-0.7 branch from 65cd49a to d1367b4 Jul 29, 2019
@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

/test all

@wangzhen127 wangzhen127 force-pushed the wangzhen127:npd-0.7 branch from d1367b4 to 1c107f5 Jul 30, 2019
@wangzhen127 wangzhen127 force-pushed the wangzhen127:npd-0.7 branch 2 times, most recently from 7b8cef8 to 28eac12 Jul 30, 2019
@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2019

/hold
Hold again. In this PR, I updated the E2E test to check KubeletStart event. Currently there is a race condition. On GKE, kubelet is restarted a few times when node is just booted. Those can happen before NPD is started. Without kubernetes/node-problem-detector#319, NPD may not find any kubelet start event if all the kubelet restarts happen before NPD is started.

We should decide if we want NPD to look back from the beginning of the boot time. If yes, we need a new v0.7.1 release to include the fix. If not, we should remove the E2E test update.

@wangzhen127 wangzhen127 force-pushed the wangzhen127:npd-0.7 branch from 28eac12 to dc2af61 Aug 2, 2019
@wangzhen127 wangzhen127 changed the title Bump NPD version to v0.7.0 for GCI Bump NPD version to v0.7.1 for GCI Aug 2, 2019
@wangzhen127 wangzhen127 force-pushed the wangzhen127:npd-0.7 branch from dc2af61 to d874dbf Aug 28, 2019
@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

/hold cancel
@Random-Liu and @yguo0905, this is ready for review.

@yguo0905

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

/lgtm
/approve
for cluster/gce/gci

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@Random-Liu

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b9c6f55 into kubernetes:master Aug 28, 2019
24 checks passed
24 checks passed
cla/linuxfoundation wangzhen127 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 28, 2019
@wangzhen127 wangzhen127 deleted the wangzhen127:npd-0.7 branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.