Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine system model to get credentials for windows nodes #80764

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@liyanhui1228
Copy link
Contributor

commented Jul 30, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

In kubernetes, we get credentials from the metadata server on GCE VMs:
https://github.com/kubernetes/kubernetes/blob/v1.15.0-alpha.2/pkg/credentialprovider/gcp/metadata.go
The credentials are used to pull container images.

But it checks whether it's running on GCE VM by looking at a Linux specific file, which not works on Windows. This PR added the check for Windows node.

Determine system model to get credentials for windows nodes.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Hi @liyanhui1228. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liyanhui1228

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

/assign @yujuhong

@yujuhong

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

/ok-to-test

Could you add a release note?

@liyanhui1228

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Looks like the test failures are related to this. Not sure why it didn't pick up those fixes.

@yujuhong

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Looks good!

@yujuhong

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 30, 2019
var name string

if runtime.GOOS == "windows" {
data, err := exec.Command("wmic", "computersystem", "get", "model").Output()

This comment has been minimized.

Copy link
@yujuhong

This comment has been minimized.

Copy link
@pjh

pjh Jul 31, 2019

Contributor

I checked with a couple team members and they approved this approach. There's a small chance the result will be different in a shielded VM (with UEFI firmware instead of BIOS) - I'll test it out and will let you know if there's a difference (but don't block merge on this).

@k8s-ci-robot k8s-ci-robot requested a review from pjh Jul 30, 2019
@yujuhong

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

/retest

1 similar comment
@liyanhui1228

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

/assign @dchen1107
for approval

@pjh

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

/lgtm

@dchen1107

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, liyanhui1228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 2, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 56d7920 into kubernetes:master Aug 2, 2019
23 checks passed
23 checks passed
cla/linuxfoundation liyanhui1228 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.