Join GitHub today
Determine system model to get credentials for windows nodes #80764
What type of PR is this?
What this PR does / why we need it:
In kubernetes, we get credentials from the metadata server on GCE VMs:
But it checks whether it's running on GCE VM by looking at a Linux specific file, which not works on Windows. This PR added the check for Windows node.
Hi @liyanhui1228. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing