New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet/container: Move prober.ContainerCommandRunner to container. #8079

Merged
merged 1 commit into from May 11, 2015

Conversation

Projects
None yet
4 participants
@yifan-gu
Member

yifan-gu commented May 11, 2015

Also include the ContainerCommandRunner in Runtime interface, but
still keep the ContainerCommandRunner interface for testability.

/cc @vmarmol @yujuhong @dchen1107

kubelet/container: Move prober.ContainerCommandRunner to container.
Also include the ContainerCommandRunner in Runtime interface, but
still keep the ContainerCommandRunner interface for testability.

@googlebot googlebot added the cla: yes label May 11, 2015

@vmarmol vmarmol self-assigned this May 11, 2015

@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 11, 2015

Contributor

LGTM, thanks @yifan-gu!

Contributor

vmarmol commented May 11, 2015

LGTM, thanks @yifan-gu!

@yujuhong

This comment has been minimized.

Show comment
Hide comment
@yujuhong

yujuhong May 11, 2015

Contributor

LGTM :)

Contributor

yujuhong commented May 11, 2015

LGTM :)

vmarmol added a commit that referenced this pull request May 11, 2015

Merge pull request #8079 from yifan-gu/rm_command_runner
kubelet/container: Move prober.ContainerCommandRunner to container.

@vmarmol vmarmol merged commit 1465475 into kubernetes:master May 11, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed

@yifan-gu yifan-gu deleted the yifan-gu:rm_command_runner branch May 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment