Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use default skuname shared Azure Disk #80837
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # #80836
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Hi @rmweir. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
@andyzhangx thank you for your reply! I do not personally use it. I am from rancherlabs and we noticed that after version 1.11 users would could experience an error during PVC creation when leaving storageaccounttype/skuName blank (rancher/rancher#20315). Currently, the default for these fields is blank, yet that value is invalid for PVC creation. We feel this interferes with UX. This could be especially confusing when referencing storage classes that were made prior to 1.12, since the input is not invalid yet and worked at one time.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing