Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance Azure cloud provider code to support both AAD and ADFS authentication. #80841

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@rjaini
Copy link
Contributor

commented Aug 1, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
On Azure Stack customer can have two type of deployment
AAD
ADFS.
Currently Azure Cloud provider only support AAD and not ADFS.

Which issue(s) this PR fixes:
Fixes #80840

Special notes for your reviewer:
We need to enhance Azure cloud provider code to support both AAD and ADFS authentication.
It is needed because Azure Stack supports both AAD and ADFS authentication.

Does this PR introduce a user-facing change?:

enhance Azure cloud provider code to support both AAD and ADFS authentication.

/kind feature
/assign @feiskyer
cc @hongbin

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Hi @rjaini. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

/ok-to-test

@rjaini rjaini changed the title Enhance Azure cloud provider code to support both AAD and ADFS authentication. feat: enhance Azure cloud provider code to support both AAD and ADFS authentication. Aug 1, 2019

@rjaini

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

/ok-to-test

@rjaini

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

/retest

@feiskyer
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 1, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, rjaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 9c22ff1 into kubernetes:master Aug 1, 2019

23 checks passed

cla/linuxfoundation rjaini authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 1, 2019

@rjaini rjaini deleted the rjaini:azs_adfs branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.