Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-addon-manager to v9.0.2 #80861

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@mborsz
Copy link
Member

commented Aug 1, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This is to pickup fix for a bug in leader election (see #80575)
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kube-addon-manager has been updated to v9.0.2 to fix a bug in leader election (https://github.com/kubernetes/kubernetes/pull/80575)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/assign @wojtek-t

@mborsz

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

(BTW: I'm not sure if kubemark is still using that file after that latest migration, but maybe let's figure out this in some other PR).

Also I'm planning to cherry-pick this PR to other branches where localhost:8080 is disabled on the master, so it's useful to update kubemark there as well.

@mborsz

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

/test pull-kubernetes-e2e-gce

@mborsz

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/80861/pull-kubernetes-e2e-gce-100-performance/1156932456784334848/artifacts/e2e-80861-95a39-master/kube-addon-manager.log shows that the fix works:

INFO: Leader is e2e-80861-95a39-master

Before the fix, it was unable to detect leader and was writing an error about localhost:8080
#80575

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 231a6a7 into kubernetes:master Aug 2, 2019

20 of 23 checks passed

pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@mborsz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration e442a42 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added a commit that referenced this pull request Aug 8, 2019

Merge pull request #80907 from mborsz/automated-cherry-pick-of-#80861…
…-upstream-release-1.15

Automated cherry pick of #80861: Update kube-addon-manager to v9.0.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.