Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm reset: replace Errorf with Warningf #80862

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@drpaneas
Copy link
Contributor

commented Aug 1, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
When kubeadm reset prints an error message that looks like this:

E0731 13:57:02.240390   10336 cleanupnode.go:82] [reset] Failed to remove containers: output: time="2019-07-31T13:57:02Z" level=fatal msg="failed to connect: --runtime-endpoint is not set"
, error: exit status 1

If this is supposed to return 0 exist status, then treat these errors as warnings instead. For more info read: #80830 (comment)

Which issue(s) this PR fixes:
I haven't created an issue.

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

kubeadm: treat non-fatal errors as warnings when doing reset

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Hi @drpaneas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

thanks for the PR @drpaneas
please add a release note instead of NONE under user facing.

so that this label is removed:
do-not-merge/release-note-label-ne

you might have to follow the exact format of the PR template under .github.

the not should be in the lines of:

kubeadm: treat non-fatal errors as warnings when doing reset

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

/ok-to-test
/priority backlog

opinions on this?
@kubernetes/sig-cluster-lifecycle-pr-reviews

@yagonobre

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Thanks!
/lgtm
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

/assign @rosti

@rosti

rosti approved these changes Aug 2, 2019

Copy link
Member

left a comment

Thanks @drpaneas !
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drpaneas, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 564eff7 into kubernetes:master Aug 2, 2019

16 of 23 checks passed

pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-typecheck Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation drpaneas authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 2, 2019

@drpaneas drpaneas deleted the drpaneas:return_warnings branch Aug 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@drpaneas: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce f946a25 link /test pull-kubernetes-e2e-gce
pull-kubernetes-integration f946a25 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.