Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: fix-certs-generation-for-external-etcd #80867

Conversation

@fabriziopandini
Copy link
Member

commented Aug 1, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixes an error when using external etcd but storing some external etcd certificate in the /etcd/kuberentes/pki folder with the same name used by kubeadm for local etcd certificates.

Which issue(s) this PR fixes:
Fixes # kubernetes/kubeadm#1276

Does this PR introduce a user-facing change?:

This PR fixes an error when using external etcd but storing etcd certificates in the same folder and with the same name used by kubeadm for local etcd certificates; for an older version of kubeadm, the workaround is to avoid file name used by kubeadm for local etcd.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig cluster-lifecycle
/priority important-soon
/assign @neolit123 @rosti @yagonobre
/cc @seh

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: seh.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixes an error when using external etcd but storing some external etcd certificate in the /etcd/kuberentes/pki folder with the same name used by kubeadm for local etcd certificates.

Which issue(s) this PR fixes:
Fixes # kubernetes/kubeadm#1276

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig cluster-lifecycle
/priority important-soon
/assign @neolit123 @rosti @yagonobre
/cc @seh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

left a comment

/lgtm
/hold
thanks @fabriziopandini
please add a release note.

@yagonobre

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@yagonobre
Copy link
Member

left a comment

Thanks @fabriziopandini
/lgtm

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 44f3aaf into kubernetes:master Aug 3, 2019

23 checks passed

cla/linuxfoundation fabriziopandini authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 3, 2019

@fabriziopandini fabriziopandini deleted the fabriziopandini:fix-certs-generation-for-external-etcd branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.