Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Kubeadm: kustomize core #80905
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Would like the CLI team's feedback on the invocation of kustomize to avoid drifting implementations.
More broadly, at first glance, this seems like it makes every change to the generated static manifests a potentially breaking change (even specifying a flag can break a user that was already adding that flag themselves). What happens if user-targeted customizations no longer match generated resources (name changes, etc). Are the customizations silently dropped or does that produce an error?
@liggitt thanks for comments.
Aug 9, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing