Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify-generated-files to error on untracked files #80936

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@cblecker
Copy link
Member

commented Aug 3, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
verify-generated-files was only tracking when there was existing files in the index that hadn't been regenerated, but it doesn't track when the generator code generates a new, untracked file.

This changes the git logic so it'll track any changed OR untracked file that is created or modified by the generated_files make target.

/assign @BenTheElder
cc: @sttts @munnerz @liggitt

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

/priority critical-urgent
/sig testing

@BenTheElder
Copy link
Member

left a comment

/lgtm
/approve
Nice catch!

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 3, 2019

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

/test pull-kubernetes-integration

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

verify will fail until #80932 merges

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 3, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3e3addf into kubernetes:master Aug 3, 2019

23 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 3, 2019

@cblecker cblecker deleted the cblecker:generated-files-fix branch Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.