Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: print the stack trace of an error for klog level v>=5 #80937

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@neolit123
Copy link
Member

commented Aug 3, 2019

What this PR does / why we need it:

  • replace all stray calls of os.Exit() with util.CheckError() instead
  • CheckError() now checks if the klog verbosity level is >=5
    and shows a stack trace of the error.
  • don't call klog.Fatal in version.go.

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1266

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

kubeadm: print the stack trace of an error for klog level --v>=5

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/kind feature
/priority backlog
@kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

/hold

cmd/kubeadm/app/util/error.go Outdated Show resolved Hide resolved
@yagonobre
Copy link
Member

left a comment

Thanks @neolit123
/lgtm

cmd/kubeadm/app/util/error.go Outdated Show resolved Hide resolved
@neolit123

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

kubeadm: print the stack trace of an error for klog level v>=5
- replace all stray calls of os.Exit() to util.CheckError() instead
- CheckError() now checks if the klog verbosity level is >=5
and shows a stack trace of the error
- don't call klog.Fatal in version.go

@neolit123 neolit123 force-pushed the neolit123:1.16-error-stack-trace branch from a083938 to 2fc1913 Aug 22, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 22, 2019

@neolit123

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

as discussed during the office hours, we didn't end in full +1 vote on this, but i'd say the PR seems good.

/hold cancel
@yagonobre @rosti
PTAL for LGTM.

followups can be:

  • don't call os.Exit() / CheckError in random places, but instead only call it before the application exists. propagate cobra errors up the call stack.
  • always show stack trace on pre-release builds.

i can log issues for these with help-wanted.

@yastij
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 22, 2019

@yagonobre

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

LGTM, Thanks @neolit123

@k8s-ci-robot k8s-ci-robot merged commit 59f5b3d into kubernetes:master Aug 22, 2019

22 of 23 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.