Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndpointSlice Controller #81048

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@robscott
Copy link
Member

commented Aug 6, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This adds an EndpointSlice Controller for the new Discovery API Group, building on the earlier PR here: #80766.

Special notes for your reviewer:
Until the PR this is built on gets merged in, the diff specific to this PR can be found here: robscott/kubernetes@discovery-api...robscott:endpointslice-controller

Does this PR introduce a user-facing change?:

Adds Endpoint Slice Controller for managing new EndpointSlice resource, disabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Hi @robscott. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott robscott changed the title Endpointslice controller EndpointSlice Controller Aug 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from brendandburns and cblecker Aug 6, 2019
@fejta-bot

This comment has been minimized.

Copy link

commented Aug 6, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@freehan freehan self-assigned this Aug 6, 2019
@freehan

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/ok-to-test

@robscott robscott force-pushed the robscott:endpointslice-controller branch from ca48e8a to d259a9b Aug 7, 2019
@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/retest

3 similar comments
@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/retest

@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/retest

@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/retest

@thockin

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/hold

for sequencing

@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

/retest

@robscott robscott force-pushed the robscott:endpointslice-controller branch from 54c950b to fc94770 Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 27, 2019
@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

/retest

@thockin thockin added the lgtm label Aug 28, 2019
@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

/hold cancel

@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

/hold

@robscott robscott force-pushed the robscott:endpointslice-controller branch from fc94770 to f97c3aa Aug 29, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 29, 2019
@robscott robscott force-pushed the robscott:endpointslice-controller branch 2 times, most recently from 1fb8c6b to 32201ce Aug 29, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

@robscott robscott force-pushed the robscott:endpointslice-controller branch from 32201ce to 75f6c24 Aug 29, 2019
@Katharine

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/test pull-kubernetes-bazel-test

@thockin

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/lgtm

Why is this held?

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 29, 2019
@robscott

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

Initially was trying to get a bit more into this PR but decided to pull that out into another one, then had to rebase on dual stack changes. Should have that other PR ready soon.

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 7da9bdc into kubernetes:master Aug 29, 2019
24 checks passed
24 checks passed
cla/linuxfoundation robscott authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@robscott robscott referenced this pull request Sep 12, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.