Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
EndpointSlice Controller #81048
What type of PR is this?
What this PR does / why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @robscott. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
3 similar comments
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
On Wed, Aug 28, 2019, 7:56 PM Kubernetes Prow Robot < ***@***.***> wrote: @robscott <https://github.com/robscott>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-verify 1fb8c6b <1fb8c6b> link <https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/81048/pull-kubernetes-verify/1166878871010676738> /test pull-kubernetes-verify pull-kubernetes-bazel-test 32201ce <32201ce> link <https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/81048/pull-kubernetes-bazel-test/1166904660376686592> /test pull-kubernetes-bazel-test Full PR test history <https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=81048>. Your PR dashboard <https://gubernator.k8s.io/pr/robscott>. Please help us cut down on flakes by linking to <https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#81048?email_source=notifications&email_token=ABKWAVHIEURCEAGZVZ4O5ZDQG43ERA5CNFSM4IJ2XMKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5NB7HQ#issuecomment-526000030>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKWAVB27B73DVUGZU5E3OLQG43ERANCNFSM4IJ2XMKA> .