Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also deprecate --cloud-provider-gce-lb-src-cidrs flag in kube-apiserver #81094

Conversation

@andrewsykim
Copy link
Member

commented Aug 7, 2019

Signed-off-by: Andrew Sy Kim kiman@vmware.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The --cloud-provider-gce-lb-src-cidrs has been deprecated in the kube-controller-manager for some time now. Turns out we forgot to deprecate the same flag that exists in the kube-apiserver.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Deprecate the `--cloud-provider-gce-lb-src-cidrs` flag in the kube-apiserver. This flag will be removed once the GCE Cloud Provider is removed from kube-apiserver. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


also deprecate --cloud-provider-gce-lb-src-cidrs flag from kube-apise…
…rver

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/assign @cheftako @bowei @MrHohn
/sig cloudprovider network

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/priority important-soon

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 7, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrHohn

MrHohn approved these changes Aug 7, 2019

@k8s-ci-robot k8s-ci-robot merged commit 9690201 into kubernetes:master Aug 8, 2019

23 checks passed

cla/linuxfoundation andrewsykim authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 8, 2019

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

thanks for doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.