Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/json-iterator/go dependency to fix emtpy byte marshaling #81096

Merged

Conversation

@roycaihw
Copy link
Member

commented Aug 7, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Update github.com/json-iterator/go to v1.1.7 to pick up json-iterator/go#371. Other changes picked up: json-iterator/go@v1.1.6...v1.1.7

This fixes a bug that pretty printer marshals empty byte as null:

# create a secret with empty byte in `data`
$ cat secret.yaml 
apiVersion: v1
kind: Secret
metadata:
  name: mysecret
type: Opaque
data:
  username: YWRtaW4=
  password: ""

before the fix

curl -v -H "Accept: application/json" localhost:8080/api/v1/namespaces/default/secrets/mysecret?pretty=true
...
  "data": {
    "password": null,
    "username": "YWRtaW4="
  },

after the fix

  "data": {
    "password": "",
    "username": "YWRtaW4="
  },

Which issue(s) this PR fixes:

Fixes kubernetes-client/python#904

Special notes for your reviewer:
Note that audit log doesn't (and I think shouldn't) honor pretty parameter and therefore doesn't caught the null value in response kubernetes-client/python#904 (comment).

Does this PR introduce a user-facing change?:

Fix a bug that pretty printer marshals empty byte or uint8 slice as null

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig api-machinery

roycaihw added some commits Aug 7, 2019

update github.com/json-iterator/go to v1.1.7
using hack/pin-dependency.sh
generated
running hack/update-vendor.sh
@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3030a9d into kubernetes:master Aug 8, 2019

23 checks passed

cla/linuxfoundation roycaihw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 8, 2019

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from yliaog Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.