Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Windows server core 1809 image to July version 0709 #81106

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@YangLu1031
Copy link
Contributor

commented Aug 8, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
There is a vulnerability in windows-server-1809-v20190312, so update to latest version

Does this PR introduce a user-facing change?:

Update the GCE windows node image to include hot fixes since July.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Welcome @YangLu1031!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Hi @YangLu1031. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

/ok-to-test

Please add a release note

@pjh

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 8, 2019

@pjh

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

/retest
/approve

The image was tested in the prototype repository and passed the tests.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangLu1031, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhockenbury

This comment has been minimized.

Copy link

commented Aug 8, 2019

Does this include the KB for the windows defender fix?#75148 (comment)

And if so, should windows defender be re-enabled for the gce windows nodes?

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Does this include the KB for the windows defender fix?#75148 (comment)

And if so, should windows defender be re-enabled for the gce windows nodes?

Not sure if the image includes the fix. @pjh

Even if it does, let's wait a couple of days to make sure the tests are stable before trying to re-enabling windows defender.

@pjh

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@rhockenbury yes, this image should include that fix. As @yujuhong mentioned we'll merge this first, then try re-enabling Windows Defender next.

@pjh

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

/retest

3 similar comments
@YangLu1031

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

/retest

@YangLu1031

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 18b6ff3 into kubernetes:master Aug 9, 2019

23 checks passed

cla/linuxfoundation YangLu1031 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.