Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Skip unused volumes in VolumeManager #81163
DesiredStateOfWorldPopulator should skip a volume that is not used in any pod. "Used" means either mounted (via volumeMounts) or used as raw block device (via volumeDevices) in a container in the pod.
Especially when block feature is disabled, a block volume must not get into DesiredStateOfWorld, because it would be formatted and mounted there, potentially overwriting any existing raw block data.
Does this PR introduce a user-facing change?:
Change of Kubernetes behavior
Aug 8, 2019
I believe that the
My guess is that the other failures are flake... retesting them now to verify.
You're right, I reworked
In addition, I moved most of the code to
@wongma7, can you please take a look at the current status? I'll squash the commits if this is the way to go.
I could not find any elegant way how to e2e test this. From storage test I can't get the global mount directory or name to check in
Note that there is a small behavior change - before this PR, kubelet mounted / mapped as raw block everything that was in
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing