Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update to latest klog 0.4.0 #81164
kubernetes/klog@47ffc4e - Add test case for detecting data race
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
47ffc4e Add test case for detecting data race 959d342 Prevent data race in SetOutput* methods 34123a4 Test with golang 1.12.x bf4884f Fix the log duplication issue for --log-file dc5546c Backfill integration tests for selecting log destinations baef93d fix broken links 07b218b Add go modules files b33ae69 Add flag to include file's dir in logs 7c58910 correct documentation a4033db Code Hygene - glog to klog 941d47b Revert "Fix the log duplication issue for --log-file." 314f6c4 Update godoc for the default value of logtostderr 7eb35e2 Fix the log duplication issue for --log-file.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I wanted to run the previous experiment one more time to ensure it wasn't flake.
I didn't yet try only this PR - let me try doing that now.
That would seem to indicate the issue is not a performance issue, but an actual bug in the log rotation code (possibly when combined with the distroless environment... unexpectedly readonly filesystems, etc?)
I think that it can still be performance issue, just with distroless we're configuring stuff differently and using a different code-path.
That said, I've run scalability tests against just this PR (5k-node cluster) and the results look fine (i.e. they are comparable with head).