Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate shared metrics into component base #81173

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@logicalhan
Copy link
Contributor

commented Aug 8, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:

Moves shared adaptors for client-go metrics into comp-base. These use the internal wrapped registries and our wrapping metric framework.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP - Metrics Stability Migration]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-stability-migration.md
- [KEP - Metrics Stability Framework]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md

@logicalhan logicalhan changed the title Shared metrics Migrate shared metrics into component base Aug 8, 2019

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

/sig instrumentation
/cc @brancz @serathius

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@logicalhan: GitHub didn't allow me to request PR reviews from the following users: serathius.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/sig instrumentation
/cc @brancz @serathius

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

/remove-sig api-machinery cluster-lifecycle

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

/priority important-soon
/kind feature

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

This generally looks good. I'll be happy to get rid of those deprecated workqueue metrics :)

@logicalhan logicalhan marked this pull request as ready for review Aug 12, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

/approve

go.mod and dependency changes lgtm. deferring to @brancz on component-base/metrics review.

/hold
would like someone from test-infra to ack the staging/src/k8s.io/component-base/version/def.bzl addition, then can unhold
/cc @BenTheElder

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

/test pull-kubernetes-integration

@@ -161,6 +161,7 @@ kube::version::ldflags() {
"-X '${KUBE_GO_PACKAGE}/vendor/k8s.io/client-go/pkg/version.${key}=${val}'"
"-X '${KUBE_GO_PACKAGE}/vendor/k8s.io/kubectl/pkg/version.${key}=${val}'"
"-X '${KUBE_GO_PACKAGE}/cmd/kubeadm/app/version.${key}=${val}'"
"-X '${KUBE_GO_PACKAGE}/vendor/k8s.io/component-base/version.${key}=${val}'"

This comment has been minimized.

Copy link
@sttts

sttts Aug 21, 2019

Contributor

@stealthybox this needs follow-ups in all of our components.

This comment has been minimized.

Copy link
@sttts

sttts Aug 21, 2019

Contributor

i.e. use this, not pkg/version

This comment has been minimized.

Copy link
@logicalhan

logicalhan Aug 21, 2019

Author Contributor

This comment has been minimized.

Copy link
@logicalhan

logicalhan Aug 21, 2019

Author Contributor

Yeah, we have like a bazillion copies of this thing currently everywhere.

@sttts

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Am fine with the structure. +1 for test-infra and @brancz for final lgtm.

@logicalhan logicalhan force-pushed the logicalhan:shared-metrics branch from 53f2837 to 94b612f Aug 21, 2019

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

/cc @fejta

@k8s-ci-robot k8s-ci-robot requested a review from fejta Aug 21, 2019

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

/assign @ehashman

@piosz piosz self-assigned this Aug 22, 2019

@fejta
Copy link
Contributor

left a comment

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/hold cancel

for fejta's bazel ack

@piosz

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, liggitt, logicalhan, piosz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# See the License for the specific language governing permissions and
# limitations under the License.

# Implements hack/lib/version.sh's kube::version::ldflags() for Bazel.

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Aug 22, 2019

Member

ACK.

If this is intended to be consumed by many repos, we should probably include usage somewhere?

]

# This should match the list of vars in kube::version::ldflags
# It should also match the list of vars set in hack/print-workspace-status.sh.

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Aug 22, 2019

Member

I.E. a user will need this setup, amongst other things..

@k8s-ci-robot k8s-ci-robot merged commit fa9e1d2 into kubernetes:master Aug 22, 2019

23 checks passed

cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.