Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to VM Update call in attach/detach disk operation #81208

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@andyzhangx
Copy link
Member

commented Aug 9, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
switch to VM Update call in attach/detach disk operation

Currently, the Azure Cloud Provider is using the VM CreateOrUpdate call when e.g. detach/attaching disks to a VM. In some scenarios, this will re-create a VM that was deleted by an external application. This can lead to orphaned VMs or blocked resources. The Update function will only update an existing VM and will fail if the VM does not exist.

Which issue(s) this PR fixes:

Fixes #80980

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

switch to VM Update call in attach/detach disk operation, original CreateOrUpdate call may lead to orphaned VMs or blocked resources

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure

cc @MSSedusch

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fix: revert typo
@andyzhangx andyzhangx force-pushed the andyzhangx:vm-update branch from 9c0a6d6 to 18342a7 Aug 9, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 9, 2019
Copy link
Member

left a comment

/lgtm
/retest

@feiskyer feiskyer added this to In progress in Provider Azure via automation Aug 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit a4c5a57 into kubernetes:master Aug 9, 2019
23 checks passed
23 checks passed
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Provider Azure automation moved this from In progress to Done Aug 9, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 9, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 14, 2019
…1208-upstream-release-1.15

Automated cherry pick of #81208: fix: use Create for attach/detach disk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.