Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return CR validation errors as field errors #81212

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@liggitt
Copy link
Member

commented Aug 9, 2019

What type of PR is this?
/kind cleanup
/kind feature

What this PR does / why we need it:
Returns distinct validation errors for custom resources as field errors.

Which issue(s) this PR fixes:
Fixes #68787

Does this PR introduce a user-facing change?:

Improves validation errors for custom resources

/cc @roycaihw @jpbetz @sttts
/sig api-machinery

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to Required for GA, in progress in Custom Resource Definitions Aug 9, 2019

@liggitt liggitt force-pushed the liggitt:crd-validation branch from 285dc81 to 760457f Aug 9, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 9, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt force-pushed the liggitt:crd-validation branch from 760457f to 4bf7e3f Aug 9, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/retest

@roycaihw

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2c455e0 into kubernetes:master Aug 10, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 11, 2019

@liggitt liggitt deleted the liggitt:crd-validation branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.