Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service annotation for specifying load balancer's pip with name. #81213

Conversation

@nilo19
Copy link
Member

commented Aug 9, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add service annotation for specifying load balancer's pip with name.

Which issue(s) this PR fixes:

Fixes #73235

Does this PR introduce a user-facing change?:

Add a service annotation `service.beta.kubernetes.io/azure-pip-name` to specify the public IP name for Azure load balancer.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilo19

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/sig azure

@nilo19

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/priority important-soon

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

/ok-to-test

@nilo19 nilo19 force-pushed the nilo19:t-qini-add_annotation_to_lookup_pip_through_resource_name branch from 56b6297 to ad5151f Aug 9, 2019
@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

/test pull-kubernetes-e2e-aks-engine-azure

1 similar comment
@nilo19

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

e2e failed because of quota issues:

Operation results in exceeding quota limits of Core. Maximum allowed: 10, Current in use: 8, Additional requested: 8

cc @ritazh

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

/area provider/azure

@feiskyer feiskyer self-assigned this Aug 12, 2019
@nilo19 nilo19 force-pushed the nilo19:t-qini-add_annotation_to_lookup_pip_through_resource_name branch from f3af604 to 43207cb Aug 12, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Aug 12, 2019
@nilo19 nilo19 force-pushed the nilo19:t-qini-add_annotation_to_lookup_pip_through_resource_name branch 2 times, most recently from 461d22f to 5ba8c61 Aug 12, 2019
@nilo19 nilo19 force-pushed the nilo19:t-qini-add_annotation_to_lookup_pip_through_resource_name branch from 5ba8c61 to c056017 Aug 12, 2019
@nilo19 nilo19 force-pushed the nilo19:t-qini-add_annotation_to_lookup_pip_through_resource_name branch from c056017 to 96fc49b Aug 12, 2019
@nilo19 nilo19 force-pushed the nilo19:t-qini-add_annotation_to_lookup_pip_through_resource_name branch from 96fc49b to 3facb63 Aug 12, 2019
@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 13, 2019
Copy link
Member

left a comment

thanks, lgtm

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a12b648 into kubernetes:master Aug 13, 2019
23 checks passed
23 checks passed
cla/linuxfoundation nilo19 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 13, 2019
@nilo19 nilo19 referenced this pull request Aug 19, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.