Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the hyperkube support for cloud-controller-manager #81219

Conversation

@dims
Copy link
Member

commented Aug 9, 2019

Drop cloud-controller-manager from hyperkube in a future release. The cloud-controller-manager drags in a lot of cloud specific dependencies AND each external cloud provider will have their own version of this cloud-controller-manager. We should tell folks to use the cloud-controller-manager specific to their cloud provider.

Change-Id: Id2e23beb2805795a3a9d54d0ddee43775a8e138c

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

hyperkube will drop support for cloud-controller-manager in a future release

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@dims

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/assign @andrewsykim
/sig cloud-provider

@dims

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/priority important-soon

@dims

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/assign @thockin

@dims

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 9, 2019

@@ -63,6 +63,8 @@ func NewCloudControllerManagerCommand() *cobra.Command {

cmd := &cobra.Command{
Use: "cloud-controller-manager",
Deprecated: "please use the cloud controller manager specific " +

This comment has been minimized.

Copy link
@andrewsykim

andrewsykim Aug 9, 2019

Member

Because of the way external providers vendor cmd/cloud-controller-manager, I think this deprecation message would end up in the external providers too?

This comment has been minimized.

Copy link
@dims

dims Aug 9, 2019

Author Member

Good point. moved it! thanks @andrewsykim

@dims dims force-pushed the dims:deprecate-hyperkybe-support-for-cloud-controller-manager branch from a50c09b to fe3ab46 Aug 9, 2019

Deprecate the hyperkube support for cloud-controller-manager
Change-Id: Id2e23beb2805795a3a9d54d0ddee43775a8e138c

@dims dims force-pushed the dims:deprecate-hyperkybe-support-for-cloud-controller-manager branch from fe3ab46 to 413f22b Aug 9, 2019

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

/lgtm

Thanks @dims

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 9, 2019

@thockin

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thanks!

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 06fb339 into kubernetes:master Aug 9, 2019

22 of 23 checks passed

pull-kubernetes-local-e2e Job triggered.
Details
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e 413f22b link /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.