Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRD e2e tests for untested stable operations #81240

Merged

Conversation

@jpbetz
Copy link
Contributor

commented Aug 9, 2019

xref #81192

Adds e2e tests for:

  • list ApiextensionsV1beta1 CustomResourceDefinition
  • deletecollection ApiextensionsV1beta1 CustomResourceDefinition
  • replace ApiextensionsV1beta1 CustomResourceDefinitionStatus
  • patch ApiextensionsV1beta1 CustomResourceDefinitionStatus
  • read ApiextensionsV1beta1 CustomResourceDefinitionStatus

@jpbetz jpbetz force-pushed the jpbetz:crd-base-operations-conformance branch 10 times, most recently from f16121d to 8738c84 Aug 9, 2019

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

/retest

1 similar comment
@jpbetz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

/retest

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@jpbetz jpbetz force-pushed the jpbetz:crd-base-operations-conformance branch from 8738c84 to bd41973 Aug 14, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

a few nits, and one comment about avoiding flakes due to conflict errors. lgtm otherwise

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

/kind feature
/priority important-soon
/area custom-resources

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

a few nits, and one comment about avoiding flakes due to conflict errors. lgtm otherwise

Feedback applied. Huge thanks for catching the conflict error flake.

@jpbetz jpbetz force-pushed the jpbetz:crd-base-operations-conformance branch from 59b22c4 to 4725551 Aug 14, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9ac0470 into kubernetes:master Aug 14, 2019

23 checks passed

cla/linuxfoundation jpbetz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019

@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 15, 2019

@jpbetz jpbetz referenced this pull request Aug 17, 2019
9 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.