Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 503 for custom resource requests during server start #81244

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@liggitt
Copy link
Member

commented Aug 9, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

Ensures that requests to potential custom resource endpoints while the server is starting get a 503 error, not a 404

Which issue(s) this PR fixes:
Fixes #71218

Does this PR introduce a user-facing change?:

Resolves a transient 404 response to custom resource requests during server startup
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

/sig api-machinery
/priority important-soon

will work on an integration test exercising this

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from sttts and yue9944882 Aug 9, 2019

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

This looks right. +1 for test.

@liggitt liggitt force-pushed the liggitt:crd_startup_503 branch from d702581 to 9a58ee1 Aug 12, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XS labels Aug 12, 2019

@liggitt liggitt changed the title WIP - Return 503 for custom resource requests during server start Return 503 for custom resource requests during server start Aug 12, 2019

@liggitt liggitt force-pushed the liggitt:crd_startup_503 branch from 9a58ee1 to 98b61d1 Aug 12, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

comments addressed, added tests

@liggitt liggitt force-pushed the liggitt:crd_startup_503 branch from 98b61d1 to 37c19ef Aug 12, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

flake #81238

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/retest

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Did a pass. The negotiated error handling looks great.

Thanks for the comprehensive testing.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 13, 2019

@k8s-ci-robot k8s-ci-robot merged commit 3f0a486 into kubernetes:master Aug 14, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019

@liggitt liggitt deleted the liggitt:crd_startup_503 branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.