Automated cherry pick of #80176: Make kubelet report usageNanoCores for node on Windows

[liyanhui1228]

Cherry pick of #80176 on release-1.15.

#80176: Make kubelet report usageNanoCores for node on Windows

[k8s-ci-robot]

Hi @liyanhui1228. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liyanhui1228]

/assign @yujuhong

[yujuhong]

/ok-to-test
@PatrickLang

[yujuhong]

/cc @kubernetes/patch-release-team
for cherry-pick approval

[yujuhong]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liyanhui1228, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [yujuhong]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tpepper]

/priority important-soon
as per the master branch PR.

The PR from which this is cherry picked also indicates in its body:

What type of PR is this?

/kind feature

while at the same time having a "/kind bug" label applied. This leaves things unclear for cherry picking. Generally we're looking for critical urgent bug fixes in proposed cherry picks.

I can see an argument that it's a bug, but it's also gone quite some time without being raised as an issue. The fixed issue #76740 was opened in April after 1.14's release and the declaration of Windows GA support, itself proposed as far back as 1.12 (eg: kubernetes/enhancements#116 (comment)). IF this were a critical bug I would have expected testing to expose it over the past year. Even in #76740 (comment) it seems to be acknowledged by the SIG as a known initial implementation choice for 1.14 and the initial Windows GA declaration. This then starts to feel more like an enhanced feature which is now being delivered for the first time with this PR, instead of a bug fix.

[PatrickLang]

@tpepper - what happened here is Kubernetes 1.14+ also revised the required version of metrics-server. Newer versions of metrics-server changed their behavior to include more fields required. Testing for Windows nodes didn't include e2e scenarios using metrics-server as that's an optional component and also not covered in conformance testing. Since we've had reports that people want to use metrics server, it exposed this omission.

[tpepper]

@kubernetes/patch-release-team discussed and decided to accept this as a bugfix for a minor oversight.