Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for "Application Default Credentials" to run e2e tests locally #81337

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@YangLu1031
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:
We missed the instruction to setup "Application Default Credentials" to run e2e tests locally.

Does this PR introduce a user-facing change?:

Add instruction to setup "Application Default Credentials" to run GCE Windows e2e tests locally. 
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Hi @YangLu1031. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YangLu1031

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@yujuhong: GitHub didn't allow me to request PR reviews from the following users: liyanhui1228.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @liyanhui1228

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pjh
pjh approved these changes Aug 13, 2019
cluster/gce/windows/README-GCE-Windows-kube-up.md Outdated Show resolved Hide resolved
@pjh

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

/ok-to-test

@YangLu1031 YangLu1031 force-pushed the YangLu1031:master branch from 65307fa to c419266 Aug 13, 2019
@YangLu1031

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

The failure is legit:

cluster/gce/windows/README-GCE-Windows-kube-up.md:27:58: "Credentails" is a misspelling of "Credentials"
@YangLu1031 YangLu1031 force-pushed the YangLu1031:master branch from 8cea696 to 9d68d44 Aug 14, 2019
@YangLu1031

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

/lgtm
/approve
Thanks!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangLu1031, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2974adf into kubernetes:master Aug 15, 2019
23 checks passed
23 checks passed
cla/linuxfoundation YangLu1031 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.