Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast path to podFitsOnNode #81346

Open
wants to merge 1 commit into
base: master
from

Conversation

@mrkm4ntr
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
podFitsOnNode can exit 2nd iteration immediately if addNominatedPods changes no data.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Hi @mrkm4ntr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrkm4ntr
To complete the pull request process, please assign bsalamat
You can assign the PR to them by writing /assign @bsalamat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from draveness and wgliang Aug 13, 2019

}
}
return true, metaOut, nodeInfoOut
return podsAdded, metaOut, nodeInfoOut

This comment has been minimized.

Copy link
@wgliang

wgliang Aug 13, 2019

Member

Can you add any unit tests for this change?

This comment has been minimized.

Copy link
@mrkm4ntr

mrkm4ntr Aug 13, 2019

Author Contributor

This change is for performance improvement. In k8s, is such change a target of unit tests?

@wgliang

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.