Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move service helpers to k8s.io/cloud-provider #81348

Open
wants to merge 1 commit into
base: master
from

Conversation

@yastij
Copy link
Member

commented Aug 13, 2019

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

/kind cleanup
/priority important-soon

What this PR does / why we need it: this moves the helpers used by the service controller to k8s.io/cloud-provider/service/helpers package

Which issue(s) this PR fixes: part of #81172

Special notes for your reviewer:

/assign @andrewsykim

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


move service helpers to k8s.io/cloud-provider
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yastij
To complete the pull request process, please assign thockin
You can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cheftako and m1093782566 Aug 13, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/retest

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Instinctively it feels weird to put status equality and deep copy methods in k8s.io/cloud-provider/service/helpers but not sure where else we can put them. Thoughts @dims?

@yastij

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@andrewsykim - thought about adding them as a method to the struct, but:

  • doesn't seem semantically right (in fact the only place we do it is for taint/tolerations)
  • we'd need to support them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.