Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove controller_utils' validation dependency to k/k #81350

Open
wants to merge 1 commit into
base: master
from

Conversation

@yastij
Copy link
Member

commented Aug 13, 2019

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it: removes the k8s.io/kubernetes/pkg/apis/core/validation package dependency from the service_controller

Which issue(s) this PR fixes: part of #81172

Special notes for your reviewer:

/assign @andrewsykim

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


remove controller_utils dependency to k/k
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>

@yastij yastij changed the title remove controller_utils dependency to k/k remove controller_utils' validation dependency to k/k Aug 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yastij
To complete the pull request process, please assign derekwaynecarr
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/apps and removed needs-sig labels Aug 13, 2019

@k8s-ci-robot k8s-ci-robot requested review from cheftako and deads2k Aug 13, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/sig cloud-provider
/priority important-soon

@yastij

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

/assign @dims
/retest

@andrewsykim

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.