Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use subtest for table units (pkg/scheduler/*) #81356

Open

Conversation

@eloyekunle
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Update scheduler's unit table tests to use subtest

Special notes for your reviewer:
Original Issue: #63267

Packages:

  • pkg/scheduler/algorithmprovider/defaults
  • pkg/scheduler/internal/cache
  • pkg/scheduler/api/compatibility
  • pkg/scheduler/util
  • pkg/scheduler/nodeinfo

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Hi @eloyekunle. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eloyekunle
To complete the pull request process, please assign huang-wei
You can assign the PR to them by writing /assign @huang-wei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eloyekunle

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@Huang-Wei

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@eloyekunle Can you move the changes of #81357 into this one? Basically, we don't need multiples PRs for similar cleanups.

And could you do a thorough search to include other cases here?

/ok-to-test

@eloyekunle eloyekunle changed the title use subtest for table units (pkg/scheduler/algorithmprovider/defaults) use subtest for table units (pkg/scheduler/*) Aug 16, 2019

eloyekunle and others added some commits Aug 12, 2019

@eloyekunle

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@Huang-Wei I have merged the PRs into this.

@eloyekunle

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.