Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: tests: Replaces Redis image with Agnhost #81358

Open
wants to merge 1 commit into
base: master
from

Conversation

@bclau
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this?

/kind feature

/sig testing
/sig windows
/area conformance

What this PR does / why we need it:

Recently, the version of redis used in Kubernetes E2E tests has been bumped to 5.0.5 (for IPv6 support), but the latest supported version for Windows is 3.2. This can lead to failing tests, the output and behaviour can be different (see #80516). In order to prevent such failures, the amount of times the Redis image is used can be reduced..

Some tests are using the Redis image, but they do not explicitly need it. This PR replaces the usage of the Redis image with the Agnhost image in such test cases.

Which issue(s) this PR fixes:

Fixes #TBA

Special notes for your reviewer:

Affected tests:
# gce only. doesn't seem to matter what image is used, it only tests / checks the deployment itself.
should audit API calls to create, get, update, patch, delete, list, watch deployments.

# daemonset image from httpd to redis.
should not update pod when spec was updated and update strategy is OnDelete
should update pod when spec was updated and update strategy is RollingUpdate

# creates webserver replicaset, create deployment with non-existent image, rollover old replicaset for deployment with new image (redis)
deployment should support rollover

# creates webserver replicaset, creates redis deployment
RollingUpdateDeployment should delete old pods and create new ones

# creates redis deployment, waits for it to finish, updates it with webserver image
RecreateDeployment should delete old pods and create new ones

# creates webserver replcaset, creates deployment with agnhost image (with revision history limit = 0)
deployment should delete old replica sets

# creates a replication controller, applies some changes (new label, selector)
should apply a new configuration to an existing RC

# creates service, applies the same service, ensures node port stays the same.
should reuse port when apply to an existing SVC

# creates RC and service and checks kubectl describe outputs.
should check if kubectl describe prints relevant information for rc and pods

# creates RC controller, waits for pod to start, looks for specific string in pod logs.
should create services for rc 

# creates RC, patches a new annotation.
should add annotations for pods in rc

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


tests: Replaces Redis image with Agnhost
Some tests are using the Redis image, but they do not explicitly need it.
This commit replaces the usage of the Redis image with the Agnhost image
in such test cases.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bclau
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@bclau: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify 3d1024d link /test pull-kubernetes-verify
pull-kubernetes-e2e-gce 3d1024d link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PatrickLang PatrickLang added this to In Progress (v1.16) in SIG-Windows Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.