Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta1: bugfix in Event struct definition #81359

Open
wants to merge 1 commit into
base: master
from

Conversation

@ethan-daocloud
Copy link
Contributor

commented Aug 13, 2019

Signed-off-by: Guangming Wang guangming.wang@daocloud.io

What type of PR is this?

/kind bug

What this PR does / why we need it:
struct definition use wrong word, it's problematic where transfer to json. mybe a bug, maybe a cleanup, you say it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Hi @ethan-daocloud. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from gmarek and sttts Aug 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ethan-daocloud
To complete the pull request process, please assign gmarek
You can assign the PR to them by writing /assign @gmarek in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 13, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ethan-daocloud

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

/assign @gmarek

@ethan-daocloud

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

/label api-review

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

/ok-to-test

thanks for the fix, this will require regenerating API-related files. make update should rebuild everything needed, then commit the results.

@liggitt liggitt added this to Changes requested in API Reviews Aug 15, 2019

@liggitt liggitt self-assigned this Aug 15, 2019

@ethan-daocloud

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

/ok-to-test

thanks for the fix, this will require regenerating API-related files. make update should rebuild everything needed, then commit the results.

@liggitt
Thanks for your guide.
rebased to current master, run make update, and push again.
still no more change now.

@ethan-daocloud

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

/restest

v1beta1: bugfix in Event struct definition
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

@ethan-daocloud ethan-daocloud force-pushed the ethan-daocloud:patch-9 branch from 9227d4c to 41645b7 Aug 17, 2019

@ethan-daocloud

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.