Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-proxy: do not export network programming latency for deleted Endpoints #81361

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@oxddr
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
At the moment the annotation used for calculations is not set when Endpoint is deleted, causing skewed results.

Also improve logging: log name of the endpoint with its latency.

Which issue(s) this PR fixes:
ref #81360
fixes kubernetes/perf-tests#640

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

n/a

@oxddr oxddr changed the title WIP - kube-proxy: do not export network programming latency for deleted enpoints WIP - kube-proxy: do not export network programming latency for deleted Endpoints Aug 13, 2019

@oxddr oxddr changed the title WIP - kube-proxy: do not export network programming latency for deleted Endpoints kube-proxy: do not export network programming latency for deleted Endpoints Aug 13, 2019

@oxddr

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

/assign @wojtek-t

@oxddr

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

/sig scalability
/priority important-soon

pkg/proxy/endpoints.go Outdated Show resolved Hide resolved
pkg/proxy/endpoints.go Outdated Show resolved Hide resolved

@oxddr oxddr force-pushed the oxddr:kubeproxy-moar-logging branch from 11e488a to b23f12c Aug 14, 2019

@oxddr oxddr force-pushed the oxddr:kubeproxy-moar-logging branch from b23f12c to e52110e Aug 14, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Aug 14, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 14, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oxddr, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e552806 into kubernetes:master Aug 14, 2019

23 checks passed

cla/linuxfoundation oxddr authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.