Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fixes DNS tests for Windows #81363

Open
wants to merge 1 commit into
base: master
from

Conversation

@bclau
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this?

/kind failing-test

/sig testing
/sig windows
/area conformance

What this PR does / why we need it:

A previous commit replaced the usage of hostname -i with getent hosts in DNS probe commands (for testing IPv6), which breaks the Windows tests (getent hosts is a Linux-specific command that looks into the /etc/hosts file, which, on Windows, is not managed by Kubelet).

This commit addresses this issue by executing getent hosts on IPv6 clusters and hostname -i on IPv4 clusters (Windows does not support IPv6 at this moment).

Which issue(s) this PR fixes:

Fixes #81080

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


tests: Fixes DNS tests for Windows
A previous commit replaced the usage of hostname -i with getent hosts
in DNS probe commands (for testing IPv6), which breaks the Windows tests
(getent hosts is a Linux-specific command that looks into the /etc/hosts
file, which, on Windows, is not managed by Kubelet).

This commit addresses this issue by executing getent hosts on IPv6 clusters
and hostname -i on IPv4 clusters (Windows does not support IPv6 at this
moment).
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bclau
To complete the pull request process, please assign freehan
You can assign the PR to them by writing /assign @freehan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bowei and dcbw Aug 13, 2019

test/e2e/network/dns_common.go Outdated Show resolved Hide resolved

@bclau bclau force-pushed the bclau:tests/fixes-dns-tests-for-windows branch from f125f4d to a8c63d1 Aug 13, 2019

@PatrickLang PatrickLang added this to In Progress+Review in SIG-Windows Aug 13, 2019

@PatrickLang

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

/release v1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.