Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix handling of uncofirmed volumes for detaches #81369

Open
wants to merge 2 commits into
base: master
from

Conversation

@gnufied
Copy link
Member

commented Aug 13, 2019

This PR fixes two things:

  • If a volume is in unconfirmed state in ASOW then do not error while
    removing from reportAsAttached map
  • Do not report volumes in unconfirmed state to node in case of detach failures.

/kind bug

Fixes #81365

WIP: Fix handling of uncofirmed volumes for detaches
This PR fixes two things:
- If a volume is in unconfirmed state in ASOW then do not error while
removing from reportAsAttached map
- Do not report volumes in unconfirmed state to node in case of detach failures.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@gnufied: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
To complete the pull request process, please assign saad-ali
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@gnufied gnufied force-pushed the gnufied:fix-uncertain-detach branch from 591fb0a to 0684498 Aug 14, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@gnufied: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 0684498 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-integration 0684498 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.