Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Skip preprovisioned and inline volume tests if driver supports dynamic provisioning #81375
What type of PR is this?
What this PR does / why we need it:
This will help reduce the number of e2e tests.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: msau42
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
changed the title
Skip preprovisioned and inline volume tests if driver supports dynamic provisioning
Aug 13, 2019
I agree the basic idea of skipping duplicated tests between volume types.
Block volume tests for block unsupported driver will behave differently between pre-provisioned and dynamic provisioning, because they fail in different phases. For other places, I don't think that we added similar checks for different behavior.
(I will check the codes in details later, but most test codes that leverage