Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename healthz methodNames to be more consistent w/ present day usages #81376

Open
wants to merge 1 commit into
base: master
from

Conversation

@logicalhan
Copy link
Contributor

commented Aug 13, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

After introducing readyz health checks, some of these method names are no longer accurate in describing what they function on and how they function. This brings things a bit more in line with the current state today.

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logicalhan
To complete the pull request process, please assign bsalamat, sttts
You can assign the PR to them by writing /assign @bsalamat @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logicalhan logicalhan force-pushed the logicalhan:health-checks branch from f67dd5c to 2e23788 Aug 13, 2019

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

/assign @bsalamat @sttts

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.